FuelBoard Contributor
ff8a1e18d0
Two columns split by a 1pt hairline: identity on the left at a fixed 52% share so rows line up when scrolling, price and savings on the right, leading-aligned on one axis with the price dominant. The favourites star sits under the station logo, freeing the width the pounds-and-pence price needs to render in full rather than scaled or truncated. Badges stay tinted rather than filled — BEST VALUE green, CHEAPEST blue, none for nearest — and the verdict capsule is one shared view across the listing, the detail sheet and the compact summary, so wording and colour cannot drift between them. Best Value's minimum saving moves from Alerts to Settings, Fuel Savings, beside the fill size and MPG that produce the saving; the Alerts tab reads it back instead of offering it twice. Its options are now 50p steps to £5 (was 50p/£1/£2/£5), so £2.50 and £3 are reachable, with a test pinning the step, the ceiling and the store's string round-trip. The verdict capsule scales to 0.7 before truncating. Measured on a 393pt screen its copy is handed ~69pt while "Closest station" needs ~90pt, so the old 0.8 floor could not reach it and rows showed "Closest stati..." instead. Verified: Debug build clean, swift test 249/249.
34 lines
1.6 KiB
Swift
34 lines
1.6 KiB
Swift
import XCTest
|
|
#if SWIFT_PACKAGE
|
|
@testable import FuelBoardShared
|
|
#endif
|
|
|
|
/// The Best Value gate's option list.
|
|
///
|
|
/// This one array is the figure behind two user-facing things — the BEST VALUE
|
|
/// badge on a station row and the proximity alert — so its granularity is a
|
|
/// setting, not an implementation detail. It was four coarse values (50p, £1,
|
|
/// £2, £5); these tests pin the 50p step and the £5 ceiling so a later edit
|
|
/// cannot quietly coarsen it back.
|
|
final class FuelStoreBestValueThresholdTests: XCTestCase {
|
|
func testOptionsStepByFiftyPenceUpToFivePounds() {
|
|
let options = FuelStore.bestValueAlertThresholdOptionsGBP
|
|
XCTAssertEqual(options, [0.5, 1.0, 1.5, 2.0, 2.5, 3.0, 3.5, 4.0, 4.5, 5.0])
|
|
XCTAssertEqual(options.count, 10)
|
|
XCTAssertEqual(options.first, 0.5, "the floor is the cheapest worth-the-drive saving offered")
|
|
XCTAssertEqual(options.last, 5.0, "£5 is the ceiling")
|
|
}
|
|
|
|
/// The store writes the threshold as a string and, on load, rejects any
|
|
/// value that is not one of these options — falling back to the £1 default.
|
|
/// So an option that does not survive `String` → `Double` exactly would
|
|
/// silently discard the user's choice. Multiples of 0.5 are exactly
|
|
/// representable in binary, and this keeps them that way.
|
|
func testEveryOptionSurvivesTheStoresStringRoundTrip() {
|
|
for option in FuelStore.bestValueAlertThresholdOptionsGBP {
|
|
XCTAssertEqual(Double(String(option)), option,
|
|
"£\(option) does not round-trip through the store's string encoding")
|
|
}
|
|
}
|
|
}
|