Best Value page: the button says Continue in both states
The declined state had its own "Not now" label, on the theory that declining should read as a decision rather than a skip. In practice the toggle above it already shows which answer is being given, so the second label only added a second thing to read. The label is now an unconditional Continue for both states, which also let primaryTitle drop the settings value it no longer consulted. Nothing else about the page changed: the toggle still hides the sliders when off, the "can be turned on in Settings" note still appears when declined, and the settings still save as the controls move. Verified on the simulator (OCR of the rendered screens): the announcement page, and the onboarding page with the toggle both off and on, all show Continue as the bottom button. No "Not now" remains in the app's source. 180 tests, 0 failures.
This commit is contained in:
@@ -17,12 +17,12 @@ import SwiftUI
|
||||
struct BestValueIntroContent: View {
|
||||
@Binding var settings: FuelSavingsSettings
|
||||
|
||||
/// What the host's primary button should say. Declining is a first-class
|
||||
/// answer: "Not now" reads as a decision where "Continue" reads as a skip.
|
||||
static func primaryTitle(for settings: FuelSavingsSettings) -> String {
|
||||
settings.enabled
|
||||
? String(localized: "Continue", comment: "Best Value continue button")
|
||||
: String(localized: "Not now", comment: "Best Value declined button")
|
||||
/// What the host's primary button says. ONE label for both answers: the
|
||||
/// toggle already shows whether Best Value is being switched on, so a
|
||||
/// separate "Not now" for the declined case was second-guessing a choice the
|
||||
/// user could see on screen.
|
||||
static var primaryTitle: String {
|
||||
String(localized: "Continue", comment: "Best Value continue button")
|
||||
}
|
||||
|
||||
var body: some View {
|
||||
@@ -214,7 +214,7 @@ struct BestValueIntroView: View {
|
||||
VStack(spacing: 0) {
|
||||
BestValueIntroContent(settings: $settings)
|
||||
|
||||
OnboardingPrimaryButton(title: BestValueIntroContent.primaryTitle(for: settings),
|
||||
OnboardingPrimaryButton(title: BestValueIntroContent.primaryTitle,
|
||||
action: finish)
|
||||
.padding(.horizontal, 20)
|
||||
.padding(.bottom, 24)
|
||||
|
||||
Reference in New Issue
Block a user